Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor UI improvements in dark mode #1131

Closed
wants to merge 3 commits into from

Conversation

bekossy
Copy link
Member

@bekossy bekossy commented Jan 2, 2024

Issue #1024

@mmabrouk
Copy link
Member

mmabrouk commented Jan 2, 2024

Hey @bekossy can I please ask you for screenshots / video of the changes. Makes it faster to give feedback. Thank you!

@bekossy
Copy link
Member Author

bekossy commented Jan 2, 2024

Thanks @mmabrouk, here you go, I am open to feedback and thinking of better ways

Screen Shot 2024-01-02 at 1 03 02 PM Screen Shot 2024-01-02 at 1 22 58 PM Screen Shot 2024-01-03 at 8 47 49 AM

@aakrem
Copy link
Collaborator

aakrem commented Jan 3, 2024

@bekossy can you fix linting?

@mmabrouk
Copy link
Member

mmabrouk commented Jan 3, 2024

@bekossy I like the second version. I think the main issue right now with the dark mode is the button colors (blue, green..) that does not match it at all.

@bekossy bekossy closed this Jan 4, 2024
@bekossy bekossy deleted the issue-1024/-minor-ui-improvements-in-dark-mode branch January 4, 2024 00:06
@bekossy
Copy link
Member Author

bekossy commented Jan 4, 2024

Closing due to linting issue in this branch, I will working on the button colors and open a new pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants